Add common extra specs #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriel-samfira
requested changes
Jun 10, 2024
README.md
Outdated
| } | ||
| ``` | ||
|
|
||
| *NOTE*: The `extra_context` spec adds a map of key/value pairs that are expanded in the `runner_install_template`. |
There was a problem hiding this comment.
that **may** be expectedThe extra_context spec allows you to add arbitrary key/value pairs to your custom template, which enables you to write any custom template you may need.
README.md
Outdated
| The `runner_install_template` allows us to completely override the script that installs and starts the runner. In the example above, I have added a copy of the current template from `garm-provider-common`, with the adition of one line: | ||
|
|
||
| ```bash | ||
| echo "I am the override script: {{ .ExtraContext.Person }} - {{ .ExtraContext.Who }}" | sudo tee /garm-override.txt |
There was a problem hiding this comment.
Replace this with something a bit more friently/meaningful for the example. Mine was terrible.
There was a problem hiding this comment.
Updated it to do a curl to github.com and paste the output into a file
README.md
Outdated
| ``` | ||
|
|
||
| *NOTE*: The `extra_context` spec adds a map of key/value pairs that are expanded in the `runner_install_template`. | ||
| The `runner_install_template` allows us to completely override the script that installs and starts the runner. In the example above, I have added a copy of the current template from `garm-provider-common`, with the adition of one line: |
There was a problem hiding this comment.
Add a note that this is a golang template which enables all the goodies that come with it. Give some examples if possible.
There was a problem hiding this comment.
Added a note that reference golang templates and their example regarding those
fabi200123
force-pushed
the
add-common-extra-specs
branch
4 times, most recently
from
5583e5b to
674e741
Compare
fabi200123
force-pushed
the
add-common-extra-specs
branch
from
674e741 to
038ba12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the common options:
disable_updatesenable_boot_debugextra_packagesrunner_install_templateextra_contextpre_install_scripts