-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSharp Module tweak & Unity Tutorial part 1, 2b, 3 tweaks #56
CSharp Module tweak & Unity Tutorial part 1, 2b, 3 tweaks #56
Conversation
Fixed a few typos/mistakes here and there also.
from Identity to uint
kept application.runInBackground (it wasn't included) renamed many instances of "TutorialGameManager.cs" to "BitcraftMiniGameManager.cs" to represent accurate filename
…so a FilterByX fix
…d RemotePlayer.cs errors
Other than the outdated sections due to the new breaking API changes, this looks good, thanks! |
Fixed a few typos/mistakes here and there also.
from Identity to uint
kept application.runInBackground (it wasn't included) renamed many instances of "TutorialGameManager.cs" to "BitcraftMiniGameManager.cs" to represent accurate filename
…so a FilterByX fix
…d RemotePlayer.cs errors
a2a1281
to
d9a5fad
Compare
…s://github.com/Lethalchip/spacetime-docs into csharp-module-updates-and-unity-tutorial-fixes
docs/unity/part-1.md
Outdated
- [Rust](part-2a-rust) | ||
- [C#](part-2b-c-sharp) | ||
- [Rust](/docs/unity/part-2a-rust.md) | ||
- [C#](/docs/unity/part-2b-csharp.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change is wrong, the previous links work but the new ones don't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not tested this myself but the changes look reasonable to me. Thanks Chippy!
Small tweaks to CSharp module
index.md
:.Tag
property to docsIs*
usage and.Tag
usage[SpacetimeDB.Reducer(ReducerKind.XXX)]
Small tweak in Unity tutorial
part-1.md
:Fixed typos and mistakes throughout
part-2b-c-sharp.md
:Identity
touint
in Config tableThrow
typo tothrow
$""
[SpacetimeDB.Reducer(ReducerKind.Connect)]
typo (it said Init before)UpdatePlayerLoginState()
error by switchingprivate
topublic
for compileFixed typos and clarified filenames in first-half of
part-3.md
:GameManager.cs
throughout toBitcraftMiniGameManager.cs
PlayerComponent.FilterByOwnerId
=>PlayerComponent.FilterByIdentity
instead.FirstOrDefault();
's fromUIUsernameChooser.cs
as not needed.Text
to.text
onUIUsernameChooser.cs
My changes stop at around the
**Append to bottom of RemotePlayer class in RemotePlayer.cs:**
- L230.The tutorial, or the code files provided are completely outdated and cannot be followed. I noticed that @dylanh724 has a PR #37 which likely fixes these issues, and probably some of the issues I fixed above.
Anyway, I figured that I would provide my tweaks in case they are helpful to you, no worries either way.