Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSharp Module tweak & Unity Tutorial part 1, 2b, 3 tweaks #56

Conversation

Lethalchip
Copy link
Contributor

Small tweaks to CSharp module index.md:

  • Added .Tag property to docs
  • Revised example usage for both Is* usage and .Tag usage
  • Fixed "Two" to "Four" in special reducer section
  • Added examples for each [SpacetimeDB.Reducer(ReducerKind.XXX)]

Small tweak in Unity tutorial part-1.md:

  • Fixed hyperlinks to Rust CSharp part-2

Fixed typos and mistakes throughout part-2b-c-sharp.md:

  • Changed Identity to uint in Config table
  • Updated Throw typo to throw
  • Updated logging to correctly use $""
  • Fixed [SpacetimeDB.Reducer(ReducerKind.Connect)] typo (it said Init before)
  • Removed extraneous publish block, as there was already one at the end
  • Fixed UpdatePlayerLoginState() error by switching private to public for compile

Fixed typos and clarified filenames in first-half of part-3.md:

  • Renamed GameManager.cs throughout to BitcraftMiniGameManager.cs
  • Added path clarifications to various filenames throughout
  • Fixed typos on PlayerComponent.FilterByOwnerId => PlayerComponent.FilterByIdentity instead
  • Removed .FirstOrDefault();'s from UIUsernameChooser.cs as not needed
  • Corrected .Text to .text on UIUsernameChooser.cs

My changes stop at around the **Append to bottom of RemotePlayer class in RemotePlayer.cs:** - L230.

The tutorial, or the code files provided are completely outdated and cannot be followed. I noticed that @dylanh724 has a PR #37 which likely fixes these issues, and probably some of the issues I fixed above.

Anyway, I figured that I would provide my tweaks in case they are helpful to you, no worries either way.

@RReverser
Copy link
Contributor

Other than the outdated sections due to the new breaking API changes, this looks good, thanks!

@RReverser RReverser force-pushed the csharp-module-updates-and-unity-tutorial-fixes branch 2 times, most recently from a2a1281 to d9a5fad Compare June 18, 2024 13:29
- [Rust](part-2a-rust)
- [C#](part-2b-c-sharp)
- [Rust](/docs/unity/part-2a-rust.md)
- [C#](/docs/unity/part-2b-csharp.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is wrong, the previous links work but the new ones don't.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested this myself but the changes look reasonable to me. Thanks Chippy!

@jdetter jdetter merged commit 2f30893 into clockworklabs:master Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants