Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite index.md #111

Merged
merged 9 commits into from
Jan 3, 2025
Merged

Rewrite index.md #111

merged 9 commits into from
Jan 3, 2025

Conversation

kazimuth
Copy link
Contributor

Following the style guide.

I think I want to split out a new page describing the system architecture in more detail. I think the stuff on identities and addresses should go there, rather than randomly here.

Addresses https://github.com/orgs/clockworklabs/projects/22/views/52?pane=issue&itemId=87837276

@kazimuth kazimuth requested a review from gefjon November 21, 2024 19:12
@kazimuth
Copy link
Contributor Author

Eh, I kept it in here for now, and added some other information. Might as well put that stuff up front.

@kazimuth kazimuth force-pushed the jgilles/index_rewrite branch from 95ed2da to cea070c Compare November 21, 2024 22:49
Copy link
Contributor

@gefjon gefjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! This is a huge improvement.

@kazimuth kazimuth force-pushed the jgilles/index_rewrite branch from f4c40ed to f3888cc Compare December 10, 2024 17:13
@kazimuth
Copy link
Contributor Author

kazimuth commented Dec 10, 2024

I am happy with this. e: except the following.

@kazimuth
Copy link
Contributor Author

I opened #121 for making a switchable language widget, not going to do that in this PR. I am happy with this as-is.

Copy link
Contributor

@gefjon gefjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please rename "Server-Side Libraries" to "Module Libraries." We're going to try to use "Module library" and "client SDK" consistently as the names of the two developer-facing components we offer.

Copy link
Contributor

@gefjon gefjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:excellent:

@kazimuth kazimuth force-pushed the jgilles/index_rewrite branch from 22fa661 to cd43619 Compare January 3, 2025 19:29
@kazimuth kazimuth merged commit e1753ec into master Jan 3, 2025
2 checks passed
@kazimuth kazimuth deleted the jgilles/index_rewrite branch January 3, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants