SubscribeToAllTables, which hides "SELECT * FROM *"
#211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the future, we will change the implementation of this method, so that it uses "legacy subscriptions" while `SubscriptionBuilder.Subscribe` moves to using "mutable subscriptions." At that time, no other interface will be provided for using "legacy subscriptions." `SubscribeToAllTables` may also at some point be rewritten in terms of "mutable subscriptions" somehow.
cloutiertyler
approved these changes
Jan 10, 2025
1 task
|
The CI here should be fixed once #210 merges. That PR should be merged once we've pushed NuGet versions of the BSATN DLLs. |
RReverser
reviewed
Jan 14, 2025
RReverser
reviewed
Jan 14, 2025
Co-authored-by: Ingvar Stepanyan <[email protected]>
1 task
RReverser
reviewed
Jan 14, 2025
Co-authored-by: Ingvar Stepanyan <[email protected]>
RReverser
approved these changes
Jan 14, 2025
|
CI now failing due to whitespace errors |
|
Although the cost was high (see #217) I have verified that this change is working appropriately in the tutorial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Per out-of-band discussion, add
SubscriptionBuilder.SubscribeToAllTables, which abstracts overSubscriptionBuilder.Subscribe(["SELECT * FROM *"]).In the future, we will change the implementation of this method, so that it uses "legacy subscriptions" while
SubscriptionBuilder.Subscribemoves to using "mutable subscriptions." At that time, no other interface will be provided for using "legacy subscriptions."SubscribeToAllTablesmay also at some point be rewritten in terms of "mutable subscriptions" somehow.API
If the API is breaking, please state below what will break
Requires SpacetimeDB PRs
N/a
Testsuite
If you would like to run the your SDK changes in this PR against a specific SpacetimeDB branch, specify that here. This can be a branch name or a link to a PR.
SpacetimeDB branch name: master
Testing
Write instructions for a test that you performed for this PR