Start implementing IEquatable<Self> for all [SpacetimeDB.Type]s #2396
+167
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes issue identified in clockworklabs/com.clockworklabs.spacetimedbsdk#264 by implementing
IEquatable<Self>
for all[SpacetimeDB.Type]
s in C#. Also overridesGetHashCode()
andToString()
for these types, which should be helpful if users want to use them as hash map keys or print them.WIP: Still need to handle some edge cases with nullable members and add more tests.
API and ABI breaking changes
Technically API breaking, since it is possible users manually implemented
IEquatable
somewhere.It's an easy fix though.
Expected complexity level and risk
2: this is a slightly-tricky algorithm to implement due to some pitfalls in C#'s type system.
Testing