Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template #2395

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update PR template #2395

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c7fc0e
Update PR template
coolreader18 Mar 7, 2025
89162f8
Merge branch 'master' into noa/upd-pr-template
bfops Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,28 @@
# Description of Changes

Please describe your change, mention any related tickets, and so on here.
<!-- Please describe your change, mention any related tickets, and so on here. -->

# API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.
<!-- If this is an API or ABI breaking change, please apply the
corresponding GitHub label. -->

# Expected complexity level and risk

*How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.*
<!--
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

*This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.*
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

*If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.*
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways. -->

# Testing

*Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!*
<!-- Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected! -->

- [x] *Write a test you've completed here.*
- [ ] *Write a test you want a reviewer to do here, so they can check it off when they're satisfied.*
- [ ] <!-- maybe a test you want to do -->
- [ ] <!-- maybe a test you want a reviewer to do, so they can check it off when they're satisfied. -->
Loading