Update bytes_sent_to_clients when merging metrics #2352
Merged
+75
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
added
the
bugfix
joshua-spacetime
force-pushed
the
joshua/fix/bytes_sent_to_clients
branch
from
4b7dad7 to
60954b2
Compare
Centril
approved these changes
Mar 5, 2025
|
This needs to be rebased on latest master |
joshua-spacetime
force-pushed
the
joshua/fix/bytes_sent_to_clients
branch
from
60954b2 to
9d151f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
bytes_sent_to_clientswas not being updated when merging with another set of metrics. Now it is.API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
A new unit test has been added