Skip to content

Commit

Permalink
[release/v1.0.0-rc2-hotfix3]: C#: fix class names for unique column i…
Browse files Browse the repository at this point in the history 
…ndices (#2088)
  • Loading branch information
@RReverser @bfops
RReverser authored and bfops committed Jan 7, 2025
1 parent 924a05d commit ed5f461
Show file tree
Hide file tree
Showing 6 changed files with 253 additions and 278 deletions.
260 changes: 15 additions & 245 deletions ...bindings-csharp/Codegen.Tests/fixtures/diag/snapshots/ExtraCompilationErrors.verified.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -185,17 +185,17 @@ internal static readonly SpacetimeDB.BSATN.IReadWrite<System.Exception> Unsuppor
},
{/*

public sealed class TestUniqueNotEquatableUniqueIndex : UniqueIndex<TestUniqueNotEquatable, global::TestUniqueNotEquatable, int?, SpacetimeDB.BSATN.ValueOption<int, SpacetimeDB.BSATN.I32>> {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
internal TestUniqueNotEquatableUniqueIndex(TestUniqueNotEquatable handle) : base(handle, "idx_TestUniqueNotEquatable_TestUniqueNotEquatable_UniqueField_unique") {}
public sealed class UniqueFieldUniqueIndex : UniqueIndex<TestUniqueNotEquatable, global::TestUniqueNotEquatable, int?, SpacetimeDB.BSATN.ValueOption<int, SpacetimeDB.BSATN.I32>> {
^^^^^^^^^^^^^^^^^^^^^^
internal UniqueFieldUniqueIndex(TestUniqueNotEquatable handle) : base(handle, "idx_TestUniqueNotEquatable_TestUniqueNotEquatable_UniqueField_unique") {}
*/
Message: Partial declarations of 'TestUniqueNotEquatable.TestUniqueNotEquatableUniqueIndex' must not specify different base classes,
Message: The type 'int?' cannot be used as type parameter 'T' in the generic type or method 'UniqueIndex<Handle, Row, T, RW>'. The nullable type 'int?' does not satisfy the constraint of 'System.IEquatable<int?>'. Nullable types can not satisfy any interface constraints.,
Severity: Error,
Descriptor: {
Id: CS0263,
Id: CS0313,
Title: ,
HelpLink: https://msdn.microsoft.com/query/roslyn.query?appId=roslyn&k=k(CS0263),
MessageFormat: Partial declarations of '{0}' must not specify different base classes,
HelpLink: https://msdn.microsoft.com/query/roslyn.query?appId=roslyn&k=k(CS0313),
MessageFormat: The type '{3}' cannot be used as type parameter '{2}' in the generic type or method '{0}'. The nullable type '{3}' does not satisfy the constraint of '{1}'. Nullable types can not satisfy any interface constraints.,
Category: Compiler,
DefaultSeverity: Error,
IsEnabledByDefault: true,
Expand All @@ -207,248 +207,18 @@ internal static readonly SpacetimeDB.BSATN.IReadWrite<System.Exception> Unsuppor
}
},
{/*
public sealed class TestUniqueNotEquatableUniqueIndex : UniqueIndex<TestUniqueNotEquatable, global::TestUniqueNotEquatable, int?, SpacetimeDB.BSATN.ValueOption<int, SpacetimeDB.BSATN.I32>> {
internal TestUniqueNotEquatableUniqueIndex(TestUniqueNotEquatable handle) : base(handle, "idx_TestUniqueNotEquatable_TestUniqueNotEquatable_UniqueField_unique") {}
^^^^
// Important: don't move this to the base class.
public UniqueFieldUniqueIndex UniqueField => new(this);
public sealed class PrimaryKeyFieldUniqueIndex : UniqueIndex<TestUniqueNotEquatable, global::TestUniqueNotEquatable, TestEnumWithExplicitValues, SpacetimeDB.BSATN.Enum<TestEnumWithExplicitValues>> {
^^^^^^^^^^^^^^^^^^^^^^^^^^
internal PrimaryKeyFieldUniqueIndex(TestUniqueNotEquatable handle) : base(handle, "idx_TestUniqueNotEquatable_TestUniqueNotEquatable_PrimaryKeyField_unique") {}
*/
Message: 'UniqueIndex<TestUniqueNotEquatable, TestUniqueNotEquatable, int?, ValueOption<int, I32>>.UniqueIndex(TestUniqueNotEquatable, string)' is inaccessible due to its protection level,
Message: The type 'TestEnumWithExplicitValues' cannot be used as type parameter 'T' in the generic type or method 'UniqueIndex<Handle, Row, T, RW>'. There is no boxing conversion from 'TestEnumWithExplicitValues' to 'System.IEquatable<TestEnumWithExplicitValues>'.,
Severity: Error,
Descriptor: {
Id: CS0122,
Id: CS0315,
Title: ,
HelpLink: https://msdn.microsoft.com/query/roslyn.query?appId=roslyn&k=k(CS0122),
MessageFormat: '{0}' is inaccessible due to its protection level,
Category: Compiler,
DefaultSeverity: Error,
IsEnabledByDefault: true,
CustomTags: [
Compiler,
Telemetry,
NotConfigurable
]
}
},
{/*
// `globalName` in one generic definition, leading to buggy `Row?` expansion for either one or another.
public global::TestUniqueNotEquatable? Find(int? key) => DoFilter(key).Cast<global::TestUniqueNotEquatable?>().SingleOrDefault();
^^^^^^^^
public bool Update(global::TestUniqueNotEquatable row) => DoUpdate(row.UniqueField, row);
*/
Message: The name 'DoFilter' does not exist in the current context,
Severity: Error,
Descriptor: {
Id: CS0103,
Title: ,
HelpLink: https://msdn.microsoft.com/query/roslyn.query?appId=roslyn&k=k(CS0103),
MessageFormat: The name '{0}' does not exist in the current context,
Category: Compiler,
DefaultSeverity: Error,
IsEnabledByDefault: true,
CustomTags: [
Compiler,
Telemetry,
NotConfigurable
]
}
},
{/*
public global::TestUniqueNotEquatable? Find(int? key) => DoFilter(key).Cast<global::TestUniqueNotEquatable?>().SingleOrDefault();
public bool Update(global::TestUniqueNotEquatable row) => DoUpdate(row.UniqueField, row);
^^^^^^^^
}
*/
Message: The name 'DoUpdate' does not exist in the current context,
Severity: Error,
Descriptor: {
Id: CS0103,
Title: ,
HelpLink: https://msdn.microsoft.com/query/roslyn.query?appId=roslyn&k=k(CS0103),
MessageFormat: The name '{0}' does not exist in the current context,
Category: Compiler,
DefaultSeverity: Error,
IsEnabledByDefault: true,
CustomTags: [
Compiler,
Telemetry,
NotConfigurable
]
}
},
{/*
}
public TestUniqueNotEquatableUniqueIndex UniqueField => new(this);
^^^^^^^^^
public sealed class TestUniqueNotEquatableUniqueIndex : UniqueIndex<TestUniqueNotEquatable, global::TestUniqueNotEquatable, TestEnumWithExplicitValues, SpacetimeDB.BSATN.Enum<TestEnumWithExplicitValues>> {
*/
Message: The call is ambiguous between the following methods or properties: 'TestUniqueNotEquatable.TestUniqueNotEquatableUniqueIndex.TestUniqueNotEquatableUniqueIndex(TestUniqueNotEquatable)' and 'TestUniqueNotEquatable.TestUniqueNotEquatableUniqueIndex.TestUniqueNotEquatableUniqueIndex(TestUniqueNotEquatable)',
Severity: Error,
Descriptor: {
Id: CS0121,
Title: ,
HelpLink: https://msdn.microsoft.com/query/roslyn.query?appId=roslyn&k=k(CS0121),
MessageFormat: The call is ambiguous between the following methods or properties: '{0}' and '{1}',
Category: Compiler,
DefaultSeverity: Error,
IsEnabledByDefault: true,
CustomTags: [
Compiler,
Telemetry,
NotConfigurable
]
}
},
{/*
public TestUniqueNotEquatableUniqueIndex UniqueField => new(this);
public sealed class TestUniqueNotEquatableUniqueIndex : UniqueIndex<TestUniqueNotEquatable, global::TestUniqueNotEquatable, TestEnumWithExplicitValues, SpacetimeDB.BSATN.Enum<TestEnumWithExplicitValues>> {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
internal TestUniqueNotEquatableUniqueIndex(TestUniqueNotEquatable handle) : base(handle, "idx_TestUniqueNotEquatable_TestUniqueNotEquatable_PrimaryKeyField_unique") {}
*/
Message: The type 'TestUniqueNotEquatable' already contains a definition for 'TestUniqueNotEquatableUniqueIndex',
Severity: Error,
Descriptor: {
Id: CS0102,
Title: ,
HelpLink: https://msdn.microsoft.com/query/roslyn.query?appId=roslyn&k=k(CS0102),
MessageFormat: The type '{0}' already contains a definition for '{1}',
Category: Compiler,
DefaultSeverity: Error,
IsEnabledByDefault: true,
CustomTags: [
Compiler,
Telemetry,
NotConfigurable
]
}
},
{/*
public sealed class TestUniqueNotEquatableUniqueIndex : UniqueIndex<TestUniqueNotEquatable, global::TestUniqueNotEquatable, TestEnumWithExplicitValues, SpacetimeDB.BSATN.Enum<TestEnumWithExplicitValues>> {
internal TestUniqueNotEquatableUniqueIndex(TestUniqueNotEquatable handle) : base(handle, "idx_TestUniqueNotEquatable_TestUniqueNotEquatable_PrimaryKeyField_unique") {}
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
// Important: don't move this to the base class.
*/
Message: Type 'TestUniqueNotEquatable.TestUniqueNotEquatableUniqueIndex' already defines a member called 'TestUniqueNotEquatableUniqueIndex' with the same parameter types,
Severity: Error,
Descriptor: {
Id: CS0111,
Title: ,
HelpLink: https://msdn.microsoft.com/query/roslyn.query?appId=roslyn&k=k(CS0111),
MessageFormat: Type '{1}' already defines a member called '{0}' with the same parameter types,
Category: Compiler,
DefaultSeverity: Error,
IsEnabledByDefault: true,
CustomTags: [
Compiler,
Telemetry,
NotConfigurable
]
}
},
{/*
public sealed class TestUniqueNotEquatableUniqueIndex : UniqueIndex<TestUniqueNotEquatable, global::TestUniqueNotEquatable, TestEnumWithExplicitValues, SpacetimeDB.BSATN.Enum<TestEnumWithExplicitValues>> {
internal TestUniqueNotEquatableUniqueIndex(TestUniqueNotEquatable handle) : base(handle, "idx_TestUniqueNotEquatable_TestUniqueNotEquatable_PrimaryKeyField_unique") {}
^^^^
// Important: don't move this to the base class.
*/
Message: 'UniqueIndex<TestUniqueNotEquatable, TestUniqueNotEquatable, int?, ValueOption<int, I32>>.UniqueIndex(TestUniqueNotEquatable, string)' is inaccessible due to its protection level,
Severity: Error,
Descriptor: {
Id: CS0122,
Title: ,
HelpLink: https://msdn.microsoft.com/query/roslyn.query?appId=roslyn&k=k(CS0122),
MessageFormat: '{0}' is inaccessible due to its protection level,
Category: Compiler,
DefaultSeverity: Error,
IsEnabledByDefault: true,
CustomTags: [
Compiler,
Telemetry,
NotConfigurable
]
}
},
{/*
// `globalName` in one generic definition, leading to buggy `Row?` expansion for either one or another.
public global::TestUniqueNotEquatable? Find(TestEnumWithExplicitValues key) => DoFilter(key).Cast<global::TestUniqueNotEquatable?>().SingleOrDefault();
^^^^^^^^
public bool Update(global::TestUniqueNotEquatable row) => DoUpdate(row.PrimaryKeyField, row);
*/
Message: The name 'DoFilter' does not exist in the current context,
Severity: Error,
Descriptor: {
Id: CS0103,
Title: ,
HelpLink: https://msdn.microsoft.com/query/roslyn.query?appId=roslyn&k=k(CS0103),
MessageFormat: The name '{0}' does not exist in the current context,
Category: Compiler,
DefaultSeverity: Error,
IsEnabledByDefault: true,
CustomTags: [
Compiler,
Telemetry,
NotConfigurable
]
}
},
{/*
public global::TestUniqueNotEquatable? Find(TestEnumWithExplicitValues key) => DoFilter(key).Cast<global::TestUniqueNotEquatable?>().SingleOrDefault();
public bool Update(global::TestUniqueNotEquatable row) => DoUpdate(row.PrimaryKeyField, row);
^^^^^^
}
*/
Message: Type 'TestUniqueNotEquatable.TestUniqueNotEquatableUniqueIndex' already defines a member called 'Update' with the same parameter types,
Severity: Error,
Descriptor: {
Id: CS0111,
Title: ,
HelpLink: https://msdn.microsoft.com/query/roslyn.query?appId=roslyn&k=k(CS0111),
MessageFormat: Type '{1}' already defines a member called '{0}' with the same parameter types,
Category: Compiler,
DefaultSeverity: Error,
IsEnabledByDefault: true,
CustomTags: [
Compiler,
Telemetry,
NotConfigurable
]
}
},
{/*
public global::TestUniqueNotEquatable? Find(TestEnumWithExplicitValues key) => DoFilter(key).Cast<global::TestUniqueNotEquatable?>().SingleOrDefault();
public bool Update(global::TestUniqueNotEquatable row) => DoUpdate(row.PrimaryKeyField, row);
^^^^^^^^
}
*/
Message: The name 'DoUpdate' does not exist in the current context,
Severity: Error,
Descriptor: {
Id: CS0103,
Title: ,
HelpLink: https://msdn.microsoft.com/query/roslyn.query?appId=roslyn&k=k(CS0103),
MessageFormat: The name '{0}' does not exist in the current context,
Category: Compiler,
DefaultSeverity: Error,
IsEnabledByDefault: true,
CustomTags: [
Compiler,
Telemetry,
NotConfigurable
]
}
},
{/*
}
public TestUniqueNotEquatableUniqueIndex PrimaryKeyField => new(this);
^^^^^^^^^
}
*/
Message: The call is ambiguous between the following methods or properties: 'TestUniqueNotEquatable.TestUniqueNotEquatableUniqueIndex.TestUniqueNotEquatableUniqueIndex(TestUniqueNotEquatable)' and 'TestUniqueNotEquatable.TestUniqueNotEquatableUniqueIndex.TestUniqueNotEquatableUniqueIndex(TestUniqueNotEquatable)',
Severity: Error,
Descriptor: {
Id: CS0121,
Title: ,
HelpLink: https://msdn.microsoft.com/query/roslyn.query?appId=roslyn&k=k(CS0121),
MessageFormat: The call is ambiguous between the following methods or properties: '{0}' and '{1}',
HelpLink: https://msdn.microsoft.com/query/roslyn.query?appId=roslyn&k=k(CS0315),
MessageFormat: The type '{3}' cannot be used as type parameter '{2}' in the generic type or method '{0}'. There is no boxing conversion from '{3}' to '{1}'.,
Category: Compiler,
DefaultSeverity: Error,
IsEnabledByDefault: true,
Expand Down
Loading

0 comments on commit ed5f461

Please sign in to comment.