Added functionality for adding metadata using validate api #72
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elisno
reviewed
Apr 8, 2025
| @@ -114,9 +117,11 @@ def validate( | |||
| - Additional keys from a [`ThresholdedTrustworthyRAGScore`](/codex/api/python/types.validator/#class-thresholdedtrustworthyragscore) dictionary: each corresponds to a [TrustworthyRAG](/tlm/api/python/utils.rag/#class-trustworthyrag) evaluation metric, and points to the score for this evaluation as well as a boolean `is_bad` flagging whether the score falls below the corresponding threshold. | |||
| """ | |||
| scores, is_bad_response = self.detect(query, context, response, prompt, form_prompt) | |||
| metadata = {} if metadata is None else metadata | |||
| metadata = {**metadata, **scores} | |||
There was a problem hiding this comment.
Would it make sense to guard the addition of **scores behind a flag in Validator.__init__(), such as log_scores: bool = True?
Still undecided on what the default should be, but this might help make the behavior more explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Info
What changed?
What do you want the reviewer(s) to focus on?
Checklist