Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trying to fix coverage #735

Merged
merged 8 commits into from
Oct 18, 2024
+13 −4
Merged

trying to fix coverage #735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ebb553e
trying to fix coverage
pavelkomarov Oct 7, 2024
88a7824
put the coveralls call in a different job so it happens whether or no…
pavelkomarov Oct 16, 2024
f67e934
invalid yaml. trying again
pavelkomarov Oct 16, 2024
0db54a8
trying to add always() so we upload to coveralls even when a test fai…
pavelkomarov Oct 16, 2024
3a06608
added github_token, because that's what the error message said to do,…
pavelkomarov Oct 16, 2024
2d94f3e
added line to see whether .coverage file is being generated
pavelkomarov Oct 16, 2024
fd0d80d
merged with upstream
pavelkomarov Oct 17, 2024
173433e
added a cd down to the directory where the coverage report lives
pavelkomarov Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .github/workflows/testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
pip install 'numpy<2.0'
pip install matplotlib #Some imports require matplotlib
pip install scipy #To not skip tests
pip install flake8 meson-python ninja pytest
pip install flake8 meson-python ninja pytest coveralls
# if [ -f requirements.txt ]; then pip install -r requirements.txt; fi

- name: Checkout Clawpack
Expand All @@ -53,4 +53,14 @@ jobs:
- name: Test with pytest
run: |
cd ${CLAW}/pyclaw
pytest --ignore=development -k "not test_shallow_sphere"
coverage run --source=src -m pytest --ignore=development -k "not test_shallow_sphere"

- name: Upload to Coveralls
if: always()
run: |
cd ${CLAW}/pyclaw
ls -l .coverage
coveralls
env:
COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3 changes: 1 addition & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
[![Build Status](https://github.com/clawpack/pyclaw/actions/workflows/testing.yml/badge.svg)](https://github.com/clawpack/pyclaw/actions)
[![Coverage Status](https://img.shields.io/coveralls/clawpack/pyclaw.svg)](https://coveralls.io/r/clawpack/pyclaw?branch=master)

[![Coverage Status](https://coveralls.io/repos/github/clawpack/pyclaw/badge.svg?branch=master)](https://coveralls.io/r/clawpack/pyclaw?branch=master)
[![PyPI version](https://badge.fury.io/py/clawpack.svg)](https://badge.fury.io/py/clawpack)


Expand Down