Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to bitcoin 0.32.2 #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrade to bitcoin 0.32.2 #5

wants to merge 2 commits into from

Conversation

liuchengxu
Copy link

Apart from the upgrade to bitcoin 0.32.2, the second commit adds some changes that are needed when I'm using txoutset in my project.

@clarkmoody
Copy link
Owner

Could you explain a bit more about how these changes improve the library?

@liuchengxu
Copy link
Author

@clarkmoody

  • 0.32.2 is the latest version of rust-bitcoin. Without upgrading to this version, downstream users (subcoin) won't be able to use bitcoin 0.32.2 alongside txoutset.
  • subcoin supports exporting the Bitcoin state to a binary file compatible with Bitcoin Core, the second commit is necessary to properly encode the txout to produce a binary UTXO set dump. (The Encodable implementation for Script is still missing, but I'll submit a PR to address this once the current changes are merged.)

Limited111
Limited111 reviewed Dec 14, 2024
View reviewed changes
Copy link

@Limited111 Limited111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dose this speed up transactions
Anonymous

@liuchengxu
Copy link
Author

Dose this speed up transactions

I don't follow. This PR is a mere upgrade to the rust-bitcoin library, with no logical changes in txoutset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Limited111 Limited111 Limited111 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liuchengxu @clarkmoody @Limited111