feat(model): optimize the getting model to framework #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daryl-L
requested review from
Keith-CY,
yanguoyu,
PainterPuppets and
zhengjianhui
|
Please add a brief description of what this PR is for, with that we can have a quick glimpse with Besides, a reference to the feature issue could be appended in the top message for tracking |
yanguoyu
reviewed
Mar 10, 2023
Daryl-L
force-pushed
the
feature/optimize-getting-model
branch
from
9abcae2
to
530ae65
Compare
Keith-CY
reviewed
Mar 10, 2023
auto-merge was automatically disabled
March 14, 2023 06:03
Pull request was converted to draft
Daryl-L
force-pushed
the
feature/optimize-getting-model
branch
3 times, most recently
from
8475064
to
08098b0
Compare
Daryl-L
force-pushed
the
feature/optimize-getting-model
branch
8 times, most recently
from
a1b984b
to
77d9a24
Compare
Daryl-L
force-pushed
the
feature/optimize-getting-model
branch
from
847b068
to
a33b5a7
Compare
yanguoyu
reviewed
Mar 24, 2023
Daryl-L
force-pushed
the
feature/optimize-getting-model
branch
from
517039a
to
e0845d5
Compare
1. use path-to-regex to parse the path 2. use list instead of trie to save the routes 3. extract some useful function which is defined in kuai io package
Daryl-L
force-pushed
the
feature/optimize-getting-model
branch
from
588e0a7
to
c6d5ab9
Compare
|
CI failed |
Daryl-L
force-pushed
the
feature/optimize-getting-model
branch
from
c6d5ab9
to
d71f796
Compare
Keith-CY
reviewed
Apr 18, 2023
yanguoyu
approved these changes
Apr 19, 2023
Keith-CY
approved these changes
Apr 19, 2023
Daryl-L
added a commit
that referenced
this pull request
Apr 24, 2023
Co-authored-by: Chen Yu <[email protected]>
This was referenced Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to issue #160.
This PR is to optimize the getting model to framework. To achieve this, I changed the way to bind
Actor. Modify theActorProviderclass decorator to save the router path and add theParamparameter decorator to inject the parameter toStores. And I added two default decorators to be used to create cell pattern forStores, theDataCellPatternis to compare the whole data in cells and theDataPrefixCellPatternis to compare the prefix string of data in cells.