-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compile error for in6_ifreq define changes #1070
Conversation
* the same structures, leading to redefinition errors. | ||
* For the second operand, we're grateful to android/bionic, platform level 21. | ||
*/ | ||
#if !defined(_LINUX_IN6_H) && !defined(_UAPI_LINUX_IN6_H) | ||
#if !defined(_IPV6_H) && !defined(_UAPI_IPV6_H) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it hurt to say:
#if !defined(_LINUX_IN6_H) && !defined(_UAPI_LINUX_IN6_H) && !defined(_IPV6_H) && !defined(_UAPI_IPV6_H)
.....
instead ?
In fact, old code
|
The ipv6_route.h changes was brought into kernel about 4 month ago. |
Hmm, the old code was there because it fixed a problem at that time so it cannot have been completely wrong. How about we make a solution which is guaranteed to fix it by changing the name to |
In fact, before 8efff0c#diff-014ec6296bbbd370c5bdfaa6bf461503L45 the code is still use the ipv6.h, and as the comment said:
|
efd7d7f should close this |
See details in hyperboria/android#72: Replace 7 years old NACL library to modern libsodium. |
After my debian sid upgrade the latest linux-libc-dev from 4.9.30 to 4.11.6, it break the compile for in6_ifreq changes. Please help me verify the changes on different platform to make sure it do not break anything elese.