Created global style for all subheading used on GlobalHeaderComponent #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to be used as a className prop for Typography for all subheading descriptions in the GenericHeaderSection.
an issue still exists with the pages children eclipsing the bottom part of the header.
indv-header-bg and containerTeal
added theme.spacing to About styles
nrrao
reviewed
Dec 1, 2021
|
Lint has been run and everything is clean. Good eye @nrrao on the blue line. That change apparently already got merged as it's on the site so we'll need to fix it with another issue. |
|
Code Climate has analyzed commit f7e8a65 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 81.9% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can be utilized as a Typography child on GlobalHeaderComponent by adding "className='genSubheadTypo'"
Cleaned up additional styling on relevant pages.
closes #1082