Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version #34

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Bump version #34

merged 2 commits into from
Feb 7, 2025
+10 −10

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Feb 7, 2025 •
edited
Loading

🗣 Description

This pull request bumps the major version.

💭 Motivation and context

This should have been done as part of #32, as we removed support for two outdated Python versions in that PR.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@jsf9k jsf9k added the version bump This issue or pull request increments the version number label Feb 7, 2025
@jsf9k jsf9k self-assigned this Feb 7, 2025
@jsf9k jsf9k marked this pull request as ready for review February 7, 2025 17:09
@jsf9k jsf9k requested a review from a team February 7, 2025 17:10
mcdonnnj
mcdonnnj approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"extra experimental features" sounds production ready!

jsf9k added 2 commits February 7, 2025 13:02
@jsf9k
Bump version from 1.1.1 to 2.0.0
edf3cce
@jsf9k
Enable some experimental features for nix command
9205837 
These are necessary for the nix command in the bump_version.sh script
to succeed.
@jsf9k jsf9k enabled auto-merge February 7, 2025 18:02
@jsf9k jsf9k disabled auto-merge February 7, 2025 18:02
@jsf9k jsf9k merged commit 83bd077 into develop Feb 7, 2025
48 checks passed
@jsf9k jsf9k deleted the bump-version branch February 7, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@dav3r dav3r Awaiting requested review from dav3r dav3r is a code owner

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

Labels
version bump This issue or pull request increments the version number
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsf9k @mcdonnnj @dv4harr10