Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert issue templates in markdown to GitHub's issue forms #595

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

mitchelbaker-cisa
Copy link
Collaborator

@mitchelbaker-cisa mitchelbaker-cisa commented Feb 11, 2025

🗣 Description

Shout out to Lauren for starting these changes.

Converts markdown versions of "new idea" and "bug report" templates to Github's issue forms.

GitHub documentation if interested.

💭 Motivation and context

This issue would be useful because issue forms encourage specific, structured information we want included in issues, as well as required fields/input validation.

Closes #359

🧪 Testing

Check out 1-newidea.yml and 2-bugreport.yml files for formatting/consistency against the markdown templates: 💡-idea.md and 🐛-bug-report.md

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
    - [ ] Tests have been added and/or modified to cover the changes in this PR.
    - [ ] All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@mitchelbaker-cisa mitchelbaker-cisa linked an issue Feb 11, 2025 that may be closed by this pull request
1 task
@mitchelbaker-cisa mitchelbaker-cisa self-assigned this Feb 11, 2025
Comment on lines +18 to +20
- Windows
- macOS
- Linux
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dropdown is nice but we'll also want the user to enter in a specific OS versions. Windows version 10, 11 server 2022 etc
macOS version Sonoma, Sequoia etc.
Linux distro+ version: Ubuntu, kali, mint, whatever else + version i.e Ubuntu 22.04 LTS

Maybe another text box for this information?

required: true
- type: input
attributes:
label: PowerShell Version (optional)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PowerShell?
This'll be nice for ScubaGear. Restrict options to PowerShell 5.1 and 7.0+
Don't think it needs to be here for Goggles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert issue templates in markdown to Github's issue forms
4 participants