Skip to content

Create cs min v1 cs max v1 eql functions #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2025
Merged

Create cs min v1 cs max v1 eql functions #97

merged 2 commits into from
Apr 2, 2025

Conversation

yujiyokoo
Copy link
Contributor

This adds cs_min_v1 and cs_max_v1 for ORE

freshtonic
freshtonic approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@freshtonic freshtonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. I think the way you've done the NULL handling makers sense too - same semantics as normal SQL for behaviour of MIN & MAX when given NULL as input

@yujiyokoo yujiyokoo merged commit a5b6c7f into main Apr 2, 2025
4 checks passed
@yujiyokoo yujiyokoo deleted the create-cs_min_v1-cs_max_v1-eql-functions branch April 2, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freshtonic freshtonic freshtonic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yujiyokoo @freshtonic