Align with Storybook 8.2 core package layout #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
added
DO NOT MERGE
ndelangen
changed the title
ndelangen
changed the title
|
The visual changes picked up seem to be flake. somehow? When running on my local machine, the tooltips show up. |
|
Yeah those hover tooltips are flaky. I've denied and rerun the build. If the new build is the same then I will accept them. |
|
Do not merge until 8.2 is fully released. This change would lock us into supporting only 8.2+ (unsure if that's what we want to do?) I opened this mainly to showcase what needs to happen to be CPC "compliant" |
ghengeveld
approved these changes
Jul 9, 2024
ghengeveld
changed the title
ghengeveld
changed the title
ghengeveld
changed the title
ghengeveld
added
major
ghengeveld
added
release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the addon to follow "core package consolidation" changes. Various internal Storybook packages have been moved, so this updates the imports.
📦 Published PR as canary version:
3.0.0--canary.330.a7fb32f.0✨ Test out this PR locally via: