feat: Added setting for http reuse (keep-alive) #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
that makes a lot of sense, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a configuration option to set the "http reuse" aka keep-alive.
Some time after
framework-arduinoespressif32 @ 3.20003.220626 (2.0.3)the heap usage drastically increased for https calls. If one has a project that makes https calls as well as the esp32FOTA library the heap can get to a point where one runs out of memory.Since OTAs are generally not something that gets done a lot it should not consume too much of the heap especially if there is no update.
This option reduces the used heap by around
40kafter OTA check call is done.I wasn't sure if I should add this as a function or in the configuration. Please let me know if you would like any changes done.