-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI assessments #289
base: dev
Are you sure you want to change the base?
UI assessments #289
Conversation
…ontinue' controls
…oading icon, fix image render
…to ui-assessments
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The form page layout doesn't look quite the same as in the design. This is what I see
There's also a lot of styles missing and hardcoded styles. Make sure to look at the properties in the figma and match those. All the colors should be using our theme colors, and other styles like font weight, font size, border radius, etc should follow the designs. We have a full design system and components that follow this so that needs to be followed. For example, we have button component with different variants and sizes to match the buttons the design team has in their design system. To use the continue button as an example, that one would be variant of primary and size of xxl.
For the loading animation, I would like you to use framer motion, not adding the animation to the tailwind config
the assessments result page has issues too. Mostly the issues I mentioned above with hardcoding styles but also the layout is off
…voyage pages,adjust home page
I pushed some changes that I think will help you with the layout. There was some padding, and a max width applied to the entire main route which was causing issues, so I just moved that. |
Got rid of the custom animation in the tailwind.config file and replaced it animation using framer motion. |
…etter fit form page
…to ui-assessments
… handleNext, DRY up radio btns
Description
I created a page for Assessments in app.
Right now, it shows all the 3 subtasks:
AssessmentResults
AssessmentForm
ResultsLoading
Just comment out the other components if you want to see them individually.
I found out about the subtask for AssessmentPage last night, so that one is still a work in progress (pls ignore that for now).
Issue link
https://app.clickup.com/t/86b3pm1hj
Fixes # (issue)
Type of change
How Has This Been Tested?
I've tested the changes locally on:
http://localhost:3000/assessment
after using
yarn dev
used creds listed on clickup
Checklist: