Ready PR in 'In progress' should be in 'Needs review'

cheshire137 · Dec 12, 2024 · 2ed0e4d · 2ed0e4d
1 parent 5c83058
commit 2ed0e4d
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/lib/project_pull_mover/pull_request.rb b/lib/project_pull_mover/pull_request.rb
@@ -488,8 +488,9 @@ def should_have_needs_review_status?
         true
       end
 
-      already_approved_check && (has_in_progress_status? || has_conflicting_status? || has_ready_to_deploy_status? ||
-        has_not_against_main_status?)
+      has_in_progress_status? || (
+        already_approved_check && (has_conflicting_status? || has_ready_to_deploy_status? || has_not_against_main_status?)
+      )
     end
 
     sig { returns T.nilable(T::Boolean) }