Skip to content

πŸ§ͺ Use reusable-tox.yml @ tox-dev/workflow #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

webknjaz
Copy link
Member

@webknjaz webknjaz commented Apr 9, 2025

❓ What kind of change does this PR introduce?

  • 🐞 bug fix
  • 🐣 feature
  • πŸ“‹ docs update
  • πŸ“‹ tests/coverage improvement
  • πŸ“‹ refactoring
  • πŸ’₯ other

πŸ“‹ What is the related issue number (starting with #)

N/A

❓ What is the current behavior? (You can also link to an open issue here)

Copy-pasted CI setup

❓ What is the new behavior (if this is a feature change)?

The tox-centric job reused and defined externally.

πŸ“‹ Other information:

https://github.com/tox-dev/workflow

πŸ“‹ Contribution checklist:

(If you're a first-timer, check out
this guide on making great pull requests)

  • I wrote descriptive pull request text above
  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after
    the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

This change is Reviewable

@webknjaz webknjaz self-assigned this Apr 9, 2025
@webknjaz webknjaz force-pushed the maintenance/reusable-tox branch 3 times, most recently from 0f0510f to 92ef85b Compare April 10, 2025 14:08
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 83.61%. Comparing base (173a630) to head (3fb6a1c).
Report is 1 commits behind head on main.

βœ… All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #743      +/-   ##
==========================================
+ Coverage   82.81%   83.61%   +0.79%     
==========================================
  Files          38       28      -10     
  Lines        4208     4168      -40     
==========================================
  Hits         3485     3485              
+ Misses        723      683      -40     

@webknjaz webknjaz force-pushed the maintenance/reusable-tox branch 8 times, most recently from b10f3c7 to b3fae24 Compare April 12, 2025 01:35
@webknjaz webknjaz force-pushed the maintenance/reusable-tox branch 2 times, most recently from 66ce02f to 4f5989a Compare April 12, 2025 18:16
@webknjaz webknjaz force-pushed the maintenance/reusable-tox branch from 4f5989a to 3fb6a1c Compare April 12, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant