Fix group renaming #6699
Open
Fix group renaming #6699
+32
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/fix-group-renaming
branch
from
2f0ac1d to
704729f
Compare
Hocuri
approved these changes
Mar 24, 2025
| bob_chat = bob_msg.get_snapshot().chat | ||
| assert bob_chat.get_basic_snapshot().name == "Test group" | ||
|
|
||
| for name in ["Baz", "Foo bar", "Bar", "Baz", "Xyzzy", "aaa", "quux"]: |
There was a problem hiding this comment.
The test takes quite a long time because of the sleeps. The test even reproduced the bug when I replaced this with
Suggested change
| for name in ["Baz", "Foo bar", "Bar", "Baz", "Xyzzy", "aaa", "quux"]: | |
| for name in ["Baz", "Foo bar"]: |
but to be sure we could also to
Suggested change
| for name in ["Baz", "Foo bar", "Bar", "Baz", "Xyzzy", "aaa", "quux"]: | |
| for name in ["Baz", "Foo bar", "Bar"]: |
Comment on lines
+4218
to
+4220
| // If the change is received from the sync message, | ||
| // do not update timestamp. It may be long after | ||
| // the group is promoted. |
There was a problem hiding this comment.
I think it would be good to explain this more extensively, because it took me quite a long time to understand it. E.g.:
// If the change is received from sync message
// do not update timestamp. It may be long after
// the group is promoted.
// (note that `sync == Nosync` would mean
//that the change comes from a sync message)
The bug is not about sync messages. Alice is sending old timestamp so the group name is not updated for Bob. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6697
Based on #6698