Plugin: Refactor BBB to use new conference tables - refs #6153 #6161
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| */ | ||
| public function update_course_field_in_all_courses($variable, $value) | ||
| public function update_course_field_in_all_courses($variable, $value): void |
There was a problem hiding this comment.
Method name "BBBPlugin::update_course_field_in_all_courses" is not in camel caps format
public/plugin/bbb/lib/bbb.lib.php
Outdated
| ->setTitle($params['meeting_name'] ?? $this->getCurrentVideoConferenceName()) | ||
| ->setAttendeePw($attendeePassword) | ||
| ->setModeratorPw($moderatorPassword) | ||
| ->setRecord((bool)$params['record']) |
There was a problem hiding this comment.
A cast statement must be followed by a single space
public/plugin/bbb/lib/bbb.lib.php
Outdated
| Event::addEvent( | ||
| 'bbb_create_meeting', | ||
| 'meeting_id', | ||
| (int)$id, |
There was a problem hiding this comment.
A cast statement must be followed by a single space
public/plugin/bbb/lib/bbb.lib.php
Outdated
| } | ||
|
|
||
| $finalMeetingUrl = $this->joinMeeting($meetingName, true); | ||
| return $finalMeetingUrl; |
There was a problem hiding this comment.
Missing blank line before return statement
|
|
||
| $entity = $result[0]; | ||
|
|
||
| return [ |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| } | ||
|
|
||
| return []; | ||
| return [ |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| @@ -723,20 +716,40 @@ public function getMeetingInfo($params) | |||
| * | |||
| * @return array | |||
| */ | |||
| public function getMeetingParticipantInfo($meetingId, $userId) | |||
| public function getMeetingParticipantInfo($meetingId, $userId): array | |||
There was a problem hiding this comment.
Method getMeetingParticipantInfo has 28 lines of code (exceeds 25 allowed). Consider refactoring.
| ->execute(); | ||
| } | ||
|
|
||
| public function findOneArrayByMeetingAndParticipant(int $meetingId, int $participantId): ?array |
There was a problem hiding this comment.
Method findOneArrayByMeetingAndParticipant has 27 lines of code (exceeds 25 allowed). Consider refactoring.
| ]; | ||
| } | ||
|
|
||
| public function getMeetingsLight( |
There was a problem hiding this comment.
Function getMeetingsLight has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
|
Code Climate has analyzed commit cce0dda and detected 16 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
No description provided.