-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal: Add conference tracking tables: meetings, recordings, and activities - refs #4195 #6124
Conversation
@@ -0,0 +1,192 @@ | |||
<?php | |||
|
|||
declare(strict_types=1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a single space around assignment operators
/** | ||
* Conference Activity entity. | ||
*/ | ||
#[ORM\Table(name: 'conference_activity')] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
* Conference Activity entity. | ||
*/ | ||
#[ORM\Table(name: 'conference_activity')] | ||
#[ORM\Entity] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
*/ | ||
#[ORM\Table(name: 'conference_activity')] | ||
#[ORM\Entity] | ||
class ConferenceActivity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You must use "/**" style comments for a class comment
#[ORM\Entity] | ||
class ConferenceActivity | ||
{ | ||
#[ORM\Id] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
@christianbeeznest en 1.11.28 tengo un plugin_bbb_meeting_format con meeting_id, format_type y resource_url pero no veo nada similar en la migración (creo que corresponde con plugin_zoom_recording). Puedes añadir la migración de esta tabla? |
Agregado en el siguiente commit. |
class ConferenceActivity | ||
{ | ||
#[ORM\Id] | ||
#[ORM\GeneratedValue] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
{ | ||
#[ORM\Id] | ||
#[ORM\GeneratedValue] | ||
#[ORM\Column(type: 'integer')] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
#[ORM\Column(type: 'integer')] | ||
protected int $id; | ||
|
||
#[ORM\ManyToOne(targetEntity: ConferenceMeeting::class)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
protected int $id; | ||
|
||
#[ORM\ManyToOne(targetEntity: ConferenceMeeting::class)] | ||
#[ORM\JoinColumn(name: 'meeting_id', referencedColumnName: 'id', onDelete: 'CASCADE')] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
#[ORM\JoinColumn(name: 'meeting_id', referencedColumnName: 'id', onDelete: 'CASCADE')] | ||
protected ?ConferenceMeeting $meeting = null; | ||
|
||
#[ORM\ManyToOne(targetEntity: User::class)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
Code Climate has analyzed commit 5cca43f and detected 169 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
The code looks OK |
No description provided.