Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Add conference tracking tables: meetings, recordings, and activities - refs #4195 #6124

Merged
merged 3 commits into from
Mar 18, 2025

Conversation

christianbeeznest
Copy link
Contributor

No description provided.

@@ -0,0 +1,192 @@
<?php

declare(strict_types=1);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a single space around assignment operators

/**
* Conference Activity entity.
*/
#[ORM\Table(name: 'conference_activity')]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.

* Conference Activity entity.
*/
#[ORM\Table(name: 'conference_activity')]
#[ORM\Entity]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.

*/
#[ORM\Table(name: 'conference_activity')]
#[ORM\Entity]
class ConferenceActivity
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must use "/**" style comments for a class comment

#[ORM\Entity]
class ConferenceActivity
{
#[ORM\Id]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.

@ywarnier
Copy link
Member

@christianbeeznest en 1.11.28 tengo un plugin_bbb_meeting_format con meeting_id, format_type y resource_url pero no veo nada similar en la migración (creo que corresponde con plugin_zoom_recording). Puedes añadir la migración de esta tabla?

@christianbeeznest
Copy link
Contributor Author

@christianbeeznest en 1.11.28 tengo un plugin_bbb_meeting_format con meeting_id, format_type y resource_url pero no veo nada similar en la migración (creo que corresponde con plugin_zoom_recording). Puedes añadir la migración de esta tabla?

Agregado en el siguiente commit.

class ConferenceActivity
{
#[ORM\Id]
#[ORM\GeneratedValue]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.

{
#[ORM\Id]
#[ORM\GeneratedValue]
#[ORM\Column(type: 'integer')]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.

#[ORM\Column(type: 'integer')]
protected int $id;

#[ORM\ManyToOne(targetEntity: ConferenceMeeting::class)]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.

protected int $id;

#[ORM\ManyToOne(targetEntity: ConferenceMeeting::class)]
#[ORM\JoinColumn(name: 'meeting_id', referencedColumnName: 'id', onDelete: 'CASCADE')]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.

#[ORM\JoinColumn(name: 'meeting_id', referencedColumnName: 'id', onDelete: 'CASCADE')]
protected ?ConferenceMeeting $meeting = null;

#[ORM\ManyToOne(targetEntity: User::class)]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.

Copy link

codeclimate bot commented Mar 13, 2025

Code Climate has analyzed commit 5cca43f and detected 169 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 161
Bug Risk 4
Clarity 4

View more on Code Climate.

@ywarnier ywarnier merged commit c36d688 into chamilo:master Mar 18, 2025
3 of 7 checks passed
@ywarnier
Copy link
Member

The code looks OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants