Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(date-picker): Introduced isOutsideVisibleRangeEnabled #2220

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

IvanKalinin
Copy link

📝 Description

This PR addressed the issue with date-picker, where it is not possible to make dates out of visible range clickable.
More details are covered in the discussion.

⛳️ Current behavior (updates)

E.g. when January 2025 is selected, the dates outside the range but present on the screen (Dec 29-31 and Feb 1-2) are disabled. Currently, there is no way to make them interactive.

🚀 New behavior

Setting isOutsideVisibleRangeEnabled: true allows us to make the dates described above clickable.

💣 Is this a breaking change (Yes/No):

No

Copy link

changeset-bot bot commented Feb 4, 2025

⚠️ No Changeset found

Latest commit: 440de5c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zag-solid ✅ Ready (Inspect) Visit Preview Feb 4, 2025 6:13am
zag-svelte ✅ Ready (Inspect) Visit Preview Feb 4, 2025 6:13am
zag-vue ✅ Ready (Inspect) Visit Preview Feb 4, 2025 6:13am
zag-website ✅ Ready (Inspect) Visit Preview Feb 4, 2025 6:13am

Copy link

vercel bot commented Feb 4, 2025

@IvanKalinin is attempting to deploy a commit to the Chakra UI Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant