change postinstall to pretest script.
#73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43081j
reviewed
Nov 3, 2023
package.json
Outdated
| @@ -27,6 +27,7 @@ | |||
| "bench": "node bench", | |||
| "lint": "eslint --ignore-path .gitignore .", | |||
| "semantic-release": "semantic-release pre && npm publish && semantic-release post", | |||
| "pretest": "npx playwright install", | |||
There was a problem hiding this comment.
scripts already have the npm binaries in PATH right? maybe this doesn't need npx? or is it this way because we may not have playwright installed as a dependency?
There was a problem hiding this comment.
You're right, but yes it seems playright isn't a direct devdep so I think this is probably best to keep as is?
There was a problem hiding this comment.
yup i think so, if it isn't a direct dependency npx will ask to install it at least
43081j
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72