SET account relation support #206
Conversation
| await assertSupportedReadModelController(model, commit as unknown as SignedCommitContainer) | ||
| }) | ||
| await Promise.all( | ||
| modelCommitsValues.filter(isSignedCommitContainer).map(async (commit: StreamCommits) => { |
There was a problem hiding this comment.
here async and await marks could be omitted. Less troubles for Node.js to unpack the promises.
There was a problem hiding this comment.
Do you have more details why it causes troubles for Node please? For V8 using async/await is more optimized than hand-written promises.
| case 'single': | ||
| runtime.accountData[key] = { type: 'node', name: modelName } | ||
| break | ||
| default: |
There was a problem hiding this comment.
We have UnreachableCaseError to have exhaustiveness check.
There was a problem hiding this comment.
Yes I might add this at some point but I'd rather avoid importing more dependencies/APIs from Ceramic if that can be avoided.
Thanks! |
There's a bunch of unrelated changes due to the breaking changes in Ceramic APIs, as well as fixing some new linting errors caught by ESLint, but the main relevant changes are:
SETvalue as theaccountRelationin the composite definition schema, as well as theaccountRelationFieldsSETaccount relation, both for a unique value (with a dedicated input) and all values (similar to theLISTaccount relation)SETaccount relationset[Model name]mutations in addition to the now deprecatedcreate[Model name]forSINGLEaccount relations, for consistency with theSETaccount relation mutations