Updated GitHub Workflow #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We failed to fetch the diff for pull request #86
You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
sebastian-j-ibanez
force-pushed
the
issue-85-update-workflows
branch
from
58fbea3 to
66fd949
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
sebastian-j-ibanez
force-pushed
the
issue-85-update-workflows
branch
6 times, most recently
from
8c849ed to
450e164
Compare
sebastian-j-ibanez
force-pushed
the
issue-85-update-workflows
branch
from
450e164 to
aa2c368
Compare
sebastian-j-ibanez
changed the title
sebastian-j-ibanez
changed the base branch from
main
to
issue-82-migrate-dependencies
yingbull
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made
Created new GitHub workflow that:
make install.mvn package -Pjspc.See issue #85 for additional details.
NOTE: This PR targets
issue-82-migrate-dependenciesbecause the migrated dependencies will make this workflow much faster and more reliable. If PR #84 is merged, I can change the base to coyote.