Fixed jsp compilation errors #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis PR addresses JSP compilation errors by adding the jspc-maven-plugin for JSP compilation, updating JSP syntax to be compliant with modern standards, and excluding problematic JSP files. The changes primarily involve replacing deprecated HTML/JSP tags and fixing import statements. Class diagram for updated JSP imports and usageclassDiagram
class BillingCodeData {
+updateCodeByName(String, String, String, String, String, String)
+addBillingCode(String, String, String)
+getBillingCodeAttr(String) : List<String>
+deletePrivateCode(String) : boolean
}
class JdbcBillingCodeImpl {
+updateCodeByName(String, String, String, String, String, String)
+addBillingCode(String, String, String)
+getBillingCodeAttr(String) : List<String>
+deletePrivateCode(String) : boolean
}
BillingCodeData <|-- JdbcBillingCodeImpl
class Logger {
+error(String)
}
class LogManager {
+getLogger(String) : Logger
}
Logger <|-- LogManager
class DemographicDao {
}
class DemographicDaoImpl {
}
DemographicDao <|-- DemographicDaoImpl
class BillingreferralDao {
}
BillingreferralDao <|-- BillingreferralDao
class CtlDocClassDao {
}
CtlDocClassDao <|-- CtlDocClassDao
class MeasurementManager {
+getFlowsheetDsHTML() : List<String>
+getPropertyValue(String) : String
}
MeasurementManager <|-- MeasurementManager
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @kateyang1998 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider creating tickets to track fixing the HTML taglib errors in the excluded JSP files (PMmodule/Admin/Bed/Bed.jsp and PMmodule/Admin/AgencyEdit/bed.jsp) rather than excluding them from compilation indefinitely.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Hey @kateyang1998, here are examples of how you can ask me to improve this pull request: @Sweep Fix the CI errors. @Sweep Add unit tests for the jspc-maven-plugin configuration to verify that JSP compilation works correctly and catches compilation errors. Tests should verify: 📖 For more information on how to use Sweep, please read our documentation. |
kateyang1998
force-pushed
the
jsp-compilation-error-fix
branch
from
63fdd71 to
bad098c
Compare
yingbull
reviewed
Nov 5, 2024
| @@ -441,11 +440,9 @@ | |||
| <td> | |||
| <label>HC Type</label> | |||
| <br/> | |||
| <select name="client.hcType"> | |||
| <c:forEach var="province" items="${GenericIntakeConstants.getProvinces()}"> | |||
| <option value="${province.value}">${province.label}</option> | |||
There was a problem hiding this comment.
Not really. I used a command to replace the HTML:HTML tag, and don't know why this file was messed up. I will revert this one.
yingbull
reviewed
Nov 5, 2024
| @@ -245,16 +245,16 @@ | |||
| } | |||
|
|
|||
| </script> | |||
| <script type="text/javascript" src="<%= request.getContextPath() %>/dojoAjax/dojo.js"></script> | |||
| <script type="text/javascript" src="<%= request.getContextPath() %>/js/AlphaTextBox.js"></script> | |||
- Added jspc dependency to compile the jsp files - Fixed jsp compilation errors
kateyang1998
force-pushed
the
jsp-compilation-error-fix
branch
from
bad098c to
e259a2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Fix JSP compilation errors by updating HTML taglib references and correcting script and link imports. Refactor JSP files to use Struts HTML tags for form elements and inputs. Add jspc-maven-plugin to the build configuration to compile JSP files, excluding certain files with known issues.
Bug Fixes:
Enhancements:
Build: