Fix method calls in DemographicRelationship

[sebastian-j-ibanez]

Changes made

• Changed Relationship deleted field to boolean (changed get and set methods accordingly).

Summary by Sourcery

Fix calls to setDeleted in deleteDemographicRelationship and refactor the method for better readability.

Bug Fixes:

• Fix incorrect call to setDeleted in deleteDemographicRelationship method.

Enhancements:

• Refactor deleteDemographicRelationship method for improved readability.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR fixes issues with the deletion flag handling in demographic relationships. The main changes involve removing an unnecessary setDeleted call during relationship creation and correcting the deletion flag setting when deleting relationships. The code also includes some structural improvements for better error handling.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Removed unnecessary initialization of deletion flag	Removed redundant setDeleted(Boolean.FALSE) call during relationship creation since it's not needed	src/main/java/oscar/oscarDemographic/data/DemographicRelationship.java
Fixed deletion flag setting and improved error handling	Changed setDeleted parameter from Boolean.TRUE to ConversionUtils.toBoolString(Boolean.TRUE) Restructured if-else condition for better readability Improved error handling flow with proper else clause	src/main/java/oscar/oscarDemographic/data/DemographicRelationship.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sweep-ai]

Hey @sebastian-j-ibanez, here are examples of how you can ask me to improve this pull request:

@Sweep Fix the CI errors.

@Sweep Add unit tests for `DemographicRelationship.deleteDemographicRelationship()` that verify:
- The deleted flag is properly set when deleting an existing relationship
- Error logging occurs when attempting to delete a non-existent relationship

📖 For more information on how to use Sweep, please read our documentation.

[sourcery-ai]

Hey @sebastian-j-ibanez - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please document why the change from Boolean.TRUE to ConversionUtils.toBoolString(Boolean.TRUE) was necessary. This seems like an important behavioral change that should be explained in the PR description.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[yingbull]

Are these stepping on changes that were made in Magenta/OpenOSP main, @sebastian-j-ibanez ?

[sebastian-j-ibanez]

I changed the deleted field to match what Magenta has (should be a boolean field).

It's good to go now.

[sebastian-j-ibanez]

Had to adjust one more setDeleted call in MigrateRelationshipsToContactsHelper.java.

It's trying to do a null check for the deleted field (which is not valid, since it's a boolean now).

[yingbull]

That's a pretty big change going from a boolean to a string - seems intentional. Is it from an upstream commit? Feels like a rebase issue and changing the method isn't the solution maybe?

[sebastian-j-ibanez]

The reason I made this change was because upstream was using a boolean.

This is what Magenta's main, alpaca, and bullfrog has (link):

public void setDeleted(boolean deleted) {
    this.deleted = deleted;
}