Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java11 upgrade #19

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Java11 upgrade #19

merged 5 commits into from
Nov 13, 2024

Conversation

garciaerin
Copy link
Collaborator

@garciaerin garciaerin commented Nov 11, 2024

  • Modified the pom.xml (added dependencies and changed the plugin version of maven compiler from 1.8 to 11).
  • Modified the Dockerfile to change the java version from 8 to 11.

Summary by Sourcery

Upgrade the project to use Java 11 by updating the Maven compiler plugin version and dependencies in pom.xml, and changing the Dockerfile to use a JDK 11 base image.

Build:

  • Update pom.xml to change Maven compiler plugin version from 1.8 to 11 and add new dependencies for Java 11 compatibility.

Deployment:

  • Modify Dockerfile to upgrade the base image from JDK 8 to JDK 11.

Copy link

sourcery-ai bot commented Nov 11, 2024

Reviewer's Guide by Sourcery

This PR upgrades the project from Java 8 to Java 11. The implementation involves updating the Maven compiler configuration and adding necessary Java 11 dependencies in pom.xml, along with updating the base Docker image to use JDK 11.

Class diagram for updated dependencies in pom.xml

classDiagram
    class ProjectDependencies {
        +Dependency jaxws-ri
        +Dependency jaxb-api
        +Dependency javax.annotation-api
    }

    class Dependency {
        +String groupId
        +String artifactId
        +String version
    }

    ProjectDependencies --> Dependency
    note for ProjectDependencies "Updated dependencies for Java 11 support"
Loading

File-Level Changes

Change Details Files
Updated Maven configuration for Java 11 compatibility
  • Changed Maven compiler source and target versions from 1.8 to 11
  • Added JAXWS-RI dependency for Java 11 XML web services support
  • Added JAXB API dependency for XML binding support
  • Added javax.annotation API dependency for common annotations
pom.xml
Updated Docker configuration to use Java 11
  • Changed base image from tomcat:9.0.56-jdk8-openjdk to tomcat:9.0.56-jdk11
.devcontainer/development/Dockerfile

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. We don't review packaging changes - Let us know if you'd like us to change this.

@yingbull yingbull self-requested a review November 11, 2024 21:35
- updated packages
- updated dependency versions
- added dependency
- uses OpenJDK version of java 11 instead of Temurin.
@yingbull yingbull merged commit a8a14a3 into develop/bullfrog Nov 13, 2024
3 of 5 checks passed
@yingbull yingbull deleted the java11-upgrade branch November 13, 2024 18:08
@kateyang1998 kateyang1998 restored the java11-upgrade branch November 19, 2024 15:57
@kateyang1998 kateyang1998 deleted the java11-upgrade branch November 19, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants