-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alpaca schema update #18
Conversation
Reviewer's Guide by SourceryThis pull request updates the database schema and hibernate queries in the Alpaca project. The main changes include updating the database character encoding to utf8mb4, setting InnoDB as the default engine, adding new SQL initialization files, and fixing hibernate query parameter placeholders. The changes aim to improve database compatibility and query performance. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sebastian-j-ibanez - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Bring schema changes from open-o-previous/revise-schema-alpaca-new to Open-O/develop-alpaca.
Changes include:
oscarinit_2024.sql
.CaseManagementNoteDAOImpl.java
.uid
column frompharmacyInfo
table.lst_orgcd
insert query indevelopment.sql
.Summary by Sourcery
Update the database schema by adding a new initialization script and modifying existing table structures. Fix Hibernate query parameter indexing in 'CaseManagementNoteDAOImpl.java'. Set default database configurations to InnoDB and utf8mb4.
New Features:
Bug Fixes:
Enhancements: