Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix variable change check in CMake
Problem description
Reconfiguring with enabled MPI after starting from a CMake configuration with MPI disabled results in a setup with enabled MPI but deactivated MPI I/O, which is deprecated. The expected behavior is that MPI I/O is enabled if MPI is enabled.
Proposed changes
The issue arises because
$CACHE{SC_ENABLE_MPI}
reflects the current MPI setting rather than the previous one. As a result, the conditionevaluates to false, preventing the check for MPI I/O when MPI was previously disabled. To address this, I introduced a new variable,
CACHED_SC_ENABLE_MPI
, to track the last MPI setting, ensuring that the last used value ofSC_ENABLE_MPI
is preserved.