Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake build examples flag #203

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

dutkalex
Copy link

Separate the building of the tests from the building of the examples.
For reference: cburstedde/p4est#316

@cburstedde
Copy link
Owner

Cool; I'm wondering what's up with the CI?

@cburstedde
Copy link
Owner

Would you know what we need the CMake version condition for?

@dutkalex
Copy link
Author

Cool; I'm wondering what's up with the CI?

It doesn't seem related to the CMake change, since the autotools build also fails...

Would you know what we need the CMake version condition for?

No idea. It was there so I left it as is, but I really don't know what was the rationale behind

@cburstedde
Copy link
Owner

cburstedde commented Sep 27, 2024 via email

@mkirilin
Copy link
Collaborator

The PR tries to merge into the master branch. The master is from March, 2024. Github updates provided OS and packages versions on regular basis. It might be a case, that some CI updates were merged into develop only (rather than master) to react on new OS / packages versions.

@dutkalex dutkalex changed the base branch from master to develop September 27, 2024 11:37
@dutkalex
Copy link
Author

Spot-on @mkirilin. That was indeed the issue. Thanks for your help 😊

@cburstedde
Copy link
Owner

Thanks for figuring it out! We can follow up on the version tests separately.

@cburstedde cburstedde merged commit eda054a into cburstedde:develop Oct 4, 2024
14 checks passed
@dutkalex dutkalex deleted the cmake-build-examples-flag branch October 5, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants