-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake build examples flag #203
CMake build examples flag #203
Conversation
Cool; I'm wondering what's up with the CI? |
Would you know what we need the CMake version condition for? |
It doesn't seem related to the CMake change, since the autotools build also fails...
No idea. It was there so I left it as is, but I really don't know what was the rationale behind |
> Cool; I'm wondering what's up with the CI?
It doesn't seem related to the CMake change, since the autotools build also fails...
So we should have a look at the current state of the CI on the develop
branch of libsc? Maybe @mkirilin has an idea.
> Would you know what we need the CMake version condition for?
No idea. It was there so I left it as is, but I really don't know what was the rationale behind
It would be interesting to check the CMake example build code, maybe we can
remove it. @scivision may know what it is needed for?
|
The PR tries to merge into the master branch. The master is from March, 2024. Github updates provided OS and packages versions on regular basis. It might be a case, that some CI updates were merged into develop only (rather than master) to react on new OS / packages versions. |
Spot-on @mkirilin. That was indeed the issue. Thanks for your help 😊 |
Thanks for figuring it out! We can follow up on the version tests separately. |
Separate the building of the tests from the building of the examples.
For reference: cburstedde/p4est#316