Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: fix check for MPI_COMM_SHARED_TYPE using openMPI #196

Merged

Conversation

maelk3
Copy link

@maelk3 maelk3 commented Jul 16, 2024

Fix CMake check for MPI_COMM_SHARED_TYPE

Following up on issue #195

Proposed changes:
This PR checks the existence of the symbol MPI_COMM_SHARED_TYPE in the header mpi.h using check_c_source_compiles instead of check_symbol_exists.

@cburstedde
Copy link
Owner

Thanks, this looks good. I can merge, but I'm also wondering whether you'd like to contribute similar code for MPITHREAD and MPIWINSHARED.

P. S. If you would please add a line to doc/release_notes.txt and add a file doc/author_lastname.txt to release under BSD?

@maelk3
Copy link
Author

maelk3 commented Jul 18, 2024

Yes, sure! Should I make another dedicaded PR or can I add to this one?

@cburstedde
Copy link
Owner

Yes, sure! Should I make another dedicaded PR or can I add to this one?

Up to you! I don't mind having this all in the same PR due to the similarity of functions to check for.

@maelk3
Copy link
Author

maelk3 commented Jul 18, 2024

@cburstedde Done!

@cburstedde
Copy link
Owner

Thanks so much, and welcome to the team! Please let us know if there's anything else that you find needs improving.

@cburstedde cburstedde merged commit d6ea917 into cburstedde:develop Jul 18, 2024
14 checks passed
@maelk3
Copy link
Author

maelk3 commented Jul 18, 2024

Thanks!

@maelk3 maelk3 deleted the fix-cmake-openmpi-comm-type-shared-check branch July 18, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants