ci:cmake: use default GCC,Clang per OS #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks; how can we make the CI go through? |
cburstedde
reviewed
Jun 20, 2024
.github/workflows/ci_cmake.yml
Outdated
| @@ -18,27 +18,27 @@ env: | |||
| CTEST_NO_TESTS_ACTION: "error" | |||
| CMAKE_BUILD_PARALLEL_LEVEL: 4 | |||
| CTEST_PARALLEL_LEVEL: 0 | |||
| CMAKE_INSTALL_PREFIX: ~/libs | |||
There was a problem hiding this comment.
In p4est we default the install to local relative to the local directory. Would it make sense to align this?
There was a problem hiding this comment.
I'm just trying to reduce the parameters sprinkled throughout the YaML. To the CI or real computer system, it doesn't much care where it's installed, as long as it's writable.
There was a problem hiding this comment.
I see, you mean "~/local". I made this so here too.
Wondering what's going on on Windows, if this is a regression or a CI feature. |
scivision
force-pushed
the
ci-cmake
branch
3 times, most recently
from
001b2d1
to
210f587
Compare
|
Windows needed to have the $HOME variable used as PowerShell doesn't expand "~" any more. |
per Carsten, simplify compiler fanout by using only default GCC or Clang.
|
Cool, trying this out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per Carsten, simplify compiler fanout by using only default GCC or Clang.