feat: Added support for async watcher callbacks #340 #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsyncEnforcer can now also await Watcher callbacks if they are Coroutines.
|
@Nekotoxin please review |
|
|
leeqvip
suggested changes
Jan 30, 2024
|
Sure thing! |
I've added pytests to verify the functionality of async watcher callbacks. Note: I used the existing pytest for synchronous calls as a reference for creating this async version.
|
@tanasecucliciu fix linter
|
tanasecucliciu
force-pushed
the
feat/340-async-enforcer-async-update-for
branch
from
16c2489
to
6657f12
Compare
leeqvip
reviewed
Feb 3, 2024
|
|
||
| await e.save_policy() | ||
| self.assertEqual(w.notify_message, "called save policy") | ||
|
|
There was a problem hiding this comment.
Whether save_policy should also depend on auto_notify_watcher ?
There was a problem hiding this comment.
@hsluoyz I saw the same in go's casbin.
There was a problem hiding this comment.
Any updates on this issue?
There was a problem hiding this comment.
@leeqvip it should behave the same way as Go
leeqvip
approved these changes
Feb 9, 2024
|
🎉 This PR is included in version 1.36.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsyncEnforcer can now also await Watcher callbacks if they are Coroutines. Related to #340.
Fix: #340