-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update demo info for DC R Ecology #1690
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries/instructor-training/compare/md-outputs..md-outputs-PR-1690 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-07-10 17:51:23 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I found a typo (see suggestion) and I think it's worth putting the recommended episode from here in the hw/setup lists.
Co-authored-by: Sarah Brown <[email protected]>
@tobyhodges should we also add a temporary flag on the teaching demo episodes page (either in the table or the header) with information on older versions for people who already started preparing their teaching demos? We could queue another PR that removes the flag/warning in a month or something. |
Happy to add that if you feel it's necessary, @ndporter. The goal of adding notices to the lesson landing page and repository was to raise awareness of these changes before they took place, but it may still be necessary to give folks a heads-up after the fact. |
It's only for the teaching demos and mostly for people who already did their training but haven't done demos (as well as for the trainers leading the demo sessions) so we make sure everyone is (literally) on the same page as far as what episode/lesson is being used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving the thing I requested changes on.
For people who have already signed up, they can use the demo pad? maybe just a small note like:
this is new, if you signed up for a demo with the old lesson you may complete your demo using the old lesson
bd353e0
to
c0452ea
Compare
Combining these two comments from @ndporter, above:
and
I have changed my mind and think the Exploring and understanding data episode is the best starting point for teaching demos. The episode begins with |
I think this is ready to go. |
Things make way more sense now. I was looking at a cached copy in my browser of the lesson and so it was actually the previous version. Now that I have the right one:
Sorry for getting confused, though I think it will work out better in the end now. |
Co-authored-by: Nathaniel D Porter <[email protected]>
I have added a note next to each of the demo signups that included an episode from the previous version of the lesson. I will also send emails to each of those trainees so that they are definitely aware. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny tiny update to clearly signpost that this is R. but otherwise it all lgtm
Co-authored-by: Sarah Brown <[email protected]>
Thanks @brownsarahm and @ndporter |
Auto-generated via {sandpaper} Source : d6e1e8b Branch : main Author : Toby Hodges <[email protected]> Time : 2024-07-10 17:53:43 +0000 Message : Merge pull request #1690 from carpentries/1683-dc-r-ecology-demos Update demo info for DC R Ecology
Auto-generated via {sandpaper} Source : 9d98465 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-07-10 17:54:31 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : d6e1e8b Branch : main Author : Toby Hodges <[email protected]> Time : 2024-07-10 17:53:43 +0000 Message : Merge pull request #1690 from carpentries/1683-dc-r-ecology-demos Update demo info for DC R Ecology
If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.
Closes #1683
Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.
See datacarpentry/R-ecology-lesson#886 and the blog post linked from there for more context about the lesson redesign