Get bucket name directly from path to avoid calling 'listBuckets' #891
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kxm-kstlr
temporarily deployed
to
external-collaborators
GitHub Actions
Inactive
kxm-kstlr
temporarily deployed
to
external-collaborators
GitHub Actions
Inactive
kxm-kstlr
temporarily deployed
to
external-collaborators
GitHub Actions
Inactive
kxm-kstlr
temporarily deployed
to
external-collaborators
GitHub Actions
Inactive
kxm-kstlr
temporarily deployed
to
external-collaborators
GitHub Actions
Inactive
kxm-kstlr
temporarily deployed
to
external-collaborators
GitHub Actions
Inactive
kxm-kstlr
temporarily deployed
to
external-collaborators
GitHub Actions
Inactive
kxm-kstlr
temporarily deployed
to
external-collaborators
GitHub Actions
Inactive
When using S3FileStore::getBucket the AWS user needs the permission 's3:ListAllMyBuckets'. In S3FileSystemProvider::createDirectory it is checked if a bucket exists, but this uses S3FileStore::getBucket thus needing the additional permission, even if this shouldn't be the case. This commit adds S3FileStore::hasBucket to avoid the mentioned method call in S3FileSystemProvider.
kxm-kstlr
requested a deployment
to
external-collaborators
GitHub Actions
Waiting
kxm-kstlr
requested a deployment
to
external-collaborators
GitHub Actions
Waiting
kxm-kstlr
requested a deployment
to
external-collaborators
GitHub Actions
Waiting
kxm-kstlr
requested a deployment
to
external-collaborators
GitHub Actions
Waiting
kxm-kstlr
requested a deployment
to
external-collaborators
GitHub Actions
Waiting
kxm-kstlr
requested a deployment
to
external-collaborators
GitHub Actions
Waiting
kxm-kstlr
requested a deployment
to
external-collaborators
GitHub Actions
Waiting
kxm-kstlr
requested a deployment
to
external-collaborators
GitHub Actions
Waiting
kxm-kstlr
requested a deployment
to
external-collaborators
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This pull request closes #890 .
Acceptance Test
gradle clean buildstill works.Questions
Does this pull request break backward compatibility?
Does this pull request require other pull requests to be merged first?
Does this require an update of the documentation?