Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Slider): fix floating-point precision issues #18664

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamalston
Copy link
Contributor

@adamalston adamalston commented Feb 21, 2025

Closes #18557

Fixed floating-point precision issues in the Slider.

Changelog

New

  • Added types for Slider utils.

Changed

  • Fixed floating-point precision issues in the Slider.

Testing / Reviewing

yarn test packages/react/src/components/Slider

Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit dfaf948
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67b88e9a110e85000843c965
😎 Deploy Preview https://deploy-preview-18664--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit dfaf948
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67b88e9a38f3c30007db7090
😎 Deploy Preview https://deploy-preview-18664--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit dfaf948
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67b88e9aca40020008942888
😎 Deploy Preview https://deploy-preview-18664--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.97%. Comparing base (a60a4d3) to head (dfaf948).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18664      +/-   ##
==========================================
- Coverage   84.97%   84.97%   -0.01%     
==========================================
  Files         408      408              
  Lines       14542    14540       -2     
  Branches     4714     4768      +54     
==========================================
- Hits        12357    12355       -2     
  Misses       2024     2024              
  Partials      161      161              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamalston adamalston marked this pull request as ready for review February 21, 2025 15:08
@adamalston adamalston requested review from a team as code owners February 21, 2025 15:08
Copy link
Contributor

@heloiselui heloiselui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks Adam! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y]: [Range] With small step prop, right arrow key stops working after a few presses
2 participants