-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Slider): fix floating-point precision issues #18664
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18664 +/- ##
==========================================
- Coverage 84.97% 84.97% -0.01%
==========================================
Files 408 408
Lines 14542 14540 -2
Branches 4714 4768 +54
==========================================
- Hits 12357 12355 -2
Misses 2024 2024
Partials 161 161 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks Adam! 👍
Closes #18557
Fixed floating-point precision issues in the
Slider
.Changelog
New
Slider
utils.Changed
Slider
.Testing / Reviewing
yarn test packages/react/src/components/Slider