feat: QA actions #17
Closed
feat: QA actions #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lengau
force-pushed
the
work/CRAFT-3602/test-action
branch
29 times, most recently
from
468c53d to
abee794
Compare
lengau
force-pushed
the
work/CRAFT-3602/test-action
branch
from
abee794 to
c9539ca
Compare
3 tasks
Suggestion from canonical/starbase#272
dariuszd21
reviewed
Oct 23, 2024
test-python/action.yaml
Outdated
Comment on lines
26
to
34
| for UV_PYTHON in ${{ inputs.python-versions }}; do | ||
| export UV_PYTHON | ||
| echo "::group::Setup tests on Python ${UV_PYTHON}" | ||
| make setup-tests | ||
| echo "::endgroup::" | ||
| echo "::group::Run tests on Python ${UV_PYTHON}" | ||
| make "${{ inputs.target }}" | ||
| echo "::endgroup::" | ||
| done |
There was a problem hiding this comment.
Does it mean, that now all python versions will be folded and run in a single job ?
If it breaks e.g. in 3.10, 3.12 will not run, am I correct?
There was a problem hiding this comment.
Correct. I can make it run all the Python versions regardless of failures if we want, though.
lengau
force-pushed
the
work/CRAFT-3602/test-action
branch
3 times, most recently
from
e97263e to
004d207
Compare
lengau
force-pushed
the
work/CRAFT-3602/test-action
branch
from
004d207 to
cde2820
Compare
|
Superseded: #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.