fix: further adjustments to default platforms

canonical · Nov 13, 2024 · 90d09d6 · 90d09d6
1 parent 1708fcb
commit 90d09d6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/.github/workflows/self-test-qa.yaml b/.github/workflows/self-test-qa.yaml
@@ -10,7 +10,9 @@ jobs:
   test-python-custom:
     uses: ./.github/workflows/test-python.yaml
     with:
-      fast-platforms: '["ubuntu-latest"]'
+      # Test on many OS's to ensure that these workflows work everywhere.
+      # Also ensure we can add a list of tags for self-hosted runners.
+      fast-platforms: '[["jammy", "amd64"], ["jammy", "arm64"], "ubuntu-22.04", "windows-latest", "macos-latest"]'
       fast-python-versions: '["3.14"]'
       slow-platforms: '["ubuntu-latest"]'
       slow-python-versions: '["3.14"]'

diff --git a/.github/workflows/test-python.yaml b/.github/workflows/test-python.yaml
@@ -5,31 +5,31 @@ on:
       fast-platforms:
         required: false
         type: string
-        default: '["jammy", "noble", "windows-latest", "macos-latest"]'
+        default: '["jammy", "noble"]'
         description: |
-          The platforms to run unit tests on, as a JSON array.
+          The platforms to run fast tests on, as a JSON array.
       fast-python-versions:
         required: false
         type: string
         default: '["3.10", "3.11", "3.12", "3.13"]'
         description: |
-          The python versions to run unit tests on, as a JSON array.
+          The python versions to run fast tests on, as a JSON array.
       lowest-python-version:
         required: false
         type: string
         description: |
-          The Python version to run when using "lowest" resolution for unit tests.
+          The Python version to run when using "lowest" resolution for tests.
       slow-platforms:
         type: string
-        default: '["jammy", "windows-latest", "macos-latest"]'
+        default: '["jammy"]'
         description: |
-          The platforms to run integration tests on, as a JSON array.
+          The platforms to run slow tests on, as a JSON array.
       slow-python-versions:
         required: false
         type: string
         default: '["3.10"]'
         description: |
-          The python versions to run integration tests on, as a JSON array.
+          The python versions to run slow tests on, as a JSON array.
 
 jobs:
   fast:
@@ -47,7 +47,7 @@ jobs:
         uses: astral-sh/setup-uv@v3
         with:
           enable-cache: true
-          cache-suffix: ${{ matrix.platform }}
+          cache-suffix: "${{ matrix.platform }}"
       - name: Set up tests
         shell: bash
         run: |
@@ -127,7 +127,7 @@ jobs:
         uses: astral-sh/setup-uv@v3
         with:
           enable-cache: true
-          cache-suffix: ${{ matrix.platform }}
+          cache-suffix: "${{ matrix.platform }}"
       - name: Install tools
         run: |
           make setup-tests