Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing clouds #571

Merged
merged 2 commits into from
Feb 19, 2025
Merged

add missing clouds #571

merged 2 commits into from
Feb 19, 2025

Conversation

abbiesims
Copy link
Contributor

@abbiesims abbiesims commented Feb 19, 2025

Done

Adds missing Manual and MicroK8s clouds from this list

QA

@webteam-app
Copy link

Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.44%. Comparing base (043a8fb) to head (125ca14).
Report is 79 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #571       +/-   ##
===========================================
- Coverage   58.51%   48.44%   -10.07%     
===========================================
  Files           6        7        +1     
  Lines         188      258       +70     
===========================================
+ Hits          110      125       +15     
- Misses         78      133       +55     
Flag Coverage Δ
python 48.44% <ø> (-10.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@abbiesims abbiesims merged commit b394de8 into main Feb 19, 2025
7 of 8 checks passed
@abbiesims abbiesims deleted the add-missing-clouds branch February 19, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants