-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Juju ecosystem docs post-release fixes #569
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor comments
still LGTM in terms of code and QA |
@bartaz Thank you for your reaction on the Build charmed applications section. However, please note that "with Charmcraft/Flask" etc. here is supposed to mean "with Charmcraft used with the Charmcraft extension that makes charming Flask applications easy", so "Charmcraft and Flask" and "Build with Charmcraft and Flask" would not be correct paraphrases. I cannot think of better short paraphrases right now either. Feels like something that will require some more thought. Can we leave that work for a future PR? |
@tmihoc Yes, I don't mean to block this PR on that, but wanted to comment for future reference (as I see the similar approach is used across the page). |
Done
QA
Issue / Card
Fixes WD-19118