-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Juju ecosystem docs refresh #565
Conversation
805d345
to
2143670
Compare
This looks like a great improvement, but looks like the alignment is a little odd in places? The "Juju Ecosystem" title feels oddly over to the right, to me? Also the getting started section could maybe just be removed, with the button moving up to the "Install Juju" card or similar? I hacked about in DevTools a bit and did this - hopefully makes sense? |
I agree with @jnsgruk about the left-alignment of the Juju ecossytem and Getting started with Juju sections, however I think we should keep the latter as a separate section since the downstream link points to a tutorial that takes the user across all the 4 steps |
@jnsgruk @massigori should be still a separate section, we can right align it fully, however keeping it slightly indented makes it more focused on the page. My advice would be keeping it indented, as it highlights it without messing with the "happy path". However it's not a make or break change so if you're super against the indentation @abbiesims can feel free to ditch it, but it would lose some priority. Just a quick side by side |
@jnsgruk your persistence won, we can't fit the "Get started with Juju" without breaking every Vanilla system law, but I can squeeze in the CTA and we call it a day? |
Go for it |
8a743b8
to
aec79bf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #565 +/- ##
==========================================
- Coverage 58.51% 49.00% -9.51%
==========================================
Files 6 7 +1
Lines 188 251 +63
==========================================
+ Hits 110 123 +13
- Misses 78 128 +50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work! 👏 🚀
just some minor comments and questions
eccdfc3
to
4e5e1fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!!!!
Amaaaaazing work 🚀 🚀 🚀 🚀 🚀
Done
QA
/docs/juju/{doc_page}
//docs/sdk/{doc_page}
pages and make sure they redirect to RTDIssue / Card
Fixes WD-18284