Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation bar wrapping on smaller screen sizes #528

Merged
merged 1 commit into from
May 3, 2024

Conversation

abbiesims
Copy link
Contributor

Done

Adds the $breakpoint-large value to avoid the nav bar wrapping onto a new line on smaller screens. The nav bar now switches to mobile version at this new breakpoint instead.

QA

  • Go to the demo
  • Check the nav bar switches to mobile version rather than wrapping onto two lines on smaller screens

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-10734

Screenshots

Before:
Screenshot from 2024-05-03 17-19-23

After:
Screenshot from 2024-05-03 17-21-40

Nav bar shrinks to mobile version before wrapping onto new line
@webteam-app
Copy link

Copy link
Contributor

@Lukewh Lukewh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@abbiesims abbiesims merged commit 20a6994 into main May 3, 2024
6 checks passed
@abbiesims abbiesims deleted the fix/nav-bar-wrapping branch May 3, 2024 13:26
Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants