Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the dashboard gif #519

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

huwshimi
Copy link
Contributor

@huwshimi huwshimi commented Mar 6, 2024

Done

  • Update the dashboard gif for the 0.12.0 release.

QA

  • Check out this feature branch
  • Run the site using the command ./run serve
  • View the site locally in your web browser at: http://0.0.0.0:8041
  • Run through the following QA steps
  • Go to the homepage and scroll down until you get to the dashboard gif.
  • Check that the images use the new, grey theme.

@webteam-app
Copy link

Demo starting at https://juju-is-519.demos.haus

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.51%. Comparing base (2bcd595) to head (9f47a6a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #519   +/-   ##
=======================================
  Coverage   58.51%   58.51%           
=======================================
  Files           6        6           
  Lines         188      188           
=======================================
  Hits          110      110           
  Misses         78       78           
Flag Coverage Δ
python 58.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@vladimir-cucu vladimir-cucu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it inside the webteam demo link and it works as expected. 🚀 Unfortunately, navigating to the QA steps link in the QA steps gave me a 404 page.

@huwshimi huwshimi merged commit 3379252 into canonical:main Mar 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants