Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump host to .NET 9 #22

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Bump host to .NET 9 #22

merged 1 commit into from
Dec 12, 2024

Conversation

mateusrodrigues
Copy link
Member

This PR bumps the .NET host, as well as other "highest-version-wins" dependencies, to .NET 9.

@mateusrodrigues mateusrodrigues requested a review from a team as a code owner December 6, 2024 14:23
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Test Results (amd64)

73 tests  ±0   73 ✅ ±0   0s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit d2e0c46. ± Comparison against base commit 350512b.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Test Results (arm64)

73 tests  ±0   73 ✅ ±0   0s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit d2e0c46. ± Comparison against base commit 350512b.

dviererbe
dviererbe approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@dviererbe dviererbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

question: WDYT about the installer targeting .NET 9 (because it is currently still targeting .NET 8)?

@mateusrodrigues
Copy link
Member Author

@dviererbe Thanks!

question: WDYT about the installer targeting .NET 9 (because it is currently still targeting .NET 8)?

My initial thought was to leave it in an LTS release, for no special reason really. I don't mind bumping it too though.

@mateusrodrigues mateusrodrigues merged commit 45d70a7 into main Dec 12, 2024
7 checks passed
@mateusrodrigues mateusrodrigues deleted the feat/update-host branch December 12, 2024 13:10
@dviererbe
Copy link
Contributor

My initial thought was to leave it in an LTS release, for no special reason really. I don't mind bumping it too though.

I do not have a strong opinion about it too, so let's keep it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dviererbe dviererbe dviererbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateusrodrigues @dviererbe