Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installer enhancements for .NET 9 #18

Merged
merged 9 commits into from
Nov 25, 2024
Merged

Installer enhancements for .NET 9 #18

merged 9 commits into from
Nov 25, 2024

Conversation

mateusrodrigues
Copy link
Member

@mateusrodrigues mateusrodrigues commented Nov 25, 2024 •
edited
Loading

This PR includes the following enhancements for the .NET Installer:

  • Added an "End of Life" column to dotnet installer list output.
  • Created the --all flag to list both supported and unsupported releases in dotnet installer list.
  • Added "LTS" indicator to dotnet installer list.
  • Added support for the unsupported.json file from the dotnet-manifest snap.

Output example:

┌────────────┬────────────────────┬──────────────────────┬───────────┬─────────────┐
│ Version    │ .NET Runtime       │ ASP.NET Core Runtime │ SDK       │ End of Life │
├────────────┼────────────────────┼──────────────────────┼───────────┼─────────────┤
│ .NET 6 LTS │ Installed [6.0.36] │ Available            │ Available │ 11/12/2024  │
│ .NET 8 LTS │ Available          │ Available            │ Available │ 11/10/2026  │
│ .NET 9     │ Available          │ Available            │ Available │ 5/12/2026   │
└────────────┴────────────────────┴──────────────────────┴───────────┴─────────────┘

Note: Unsupported releases are shown in a different color in the output.

@mateusrodrigues mateusrodrigues requested a review from a team as a code owner November 25, 2024 12:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited
Loading

Test Results (arm64)

73 tests  ±0   73 ✅ ±0   0s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 6b19829. ± Comparison against base commit 49b4e6a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited
Loading

Test Results (amd64)

73 tests  ±0   73 ✅ ±0   0s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 6b19829. ± Comparison against base commit 49b4e6a.

♻️ This comment has been updated with latest results.

@dviererbe
refactor: rename remaining includeArchive variables
54c48fd 
The `includeUnsupported` variable was previously named `includeArchive`
in reference to the `unsupported.json` file previously named `archive.json`.

See: canonical/dotnet-manifest#6 (comment)
dviererbe
dviererbe approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@dviererbe dviererbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: I pushed a commit to rename remaining includeArchive variables

dviererbe
dviererbe approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@dviererbe dviererbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@mateusrodrigues mateusrodrigues merged commit a192462 into main Nov 25, 2024
7 checks passed
@mateusrodrigues mateusrodrigues deleted the feat/dotnet9 branch November 25, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dviererbe dviererbe dviererbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateusrodrigues @dviererbe